-
Notifications
You must be signed in to change notification settings - Fork 173
optimize uint16 parsing #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+227
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
cc: @lemire |
Member
|
Let me see if I can't get the s390x tests to work. This would test BIG ENDIAN. |
Member
|
@shikharish Please sync with our main branch. |
Signed-off-by: Shikhar <[email protected]>
Signed-off-by: Shikhar <[email protected]>
Signed-off-by: Shikhar <[email protected]>
Collaborator
Author
|
@lemire done. |
lemire
approved these changes
Jan 2, 2026
Member
lemire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I will let it sit in case others have comments.
Collaborator
Author
|
@lemire can merge? |
Member
|
Will be in the next release. |
IRainman
added a commit
to IRainman/fast_float
that referenced
this pull request
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bench_uint16.cppuint16_tparsing with a similar approach touint8_t.benchmark results(Apple M1, Apple clang 14)
old:
new:
About 47% speedup on my machine